Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hakari] [Support question] How to make dependabot play nice with hakari? #320

Open
VorpalBlade opened this issue Oct 12, 2024 · 5 comments

Comments

@VorpalBlade
Copy link

VorpalBlade commented Oct 12, 2024

So, I'm overall happy with hakari, but I have run into an issue: It doesn't play nice with dependabot for automatic updates:

  • Dependabot will try to update some indirect dependency that is mentioned as a direct dependency in the workspace hack crate to a new semver major version
  • However, the direct dependency that has this indirect dependency has not yet upgraded to that new semver major version. So we don't want the upgrade PR for the workspace crate.

See for example this dependabot PR to one of my projects: VorpalBlade/paketkoll#103

Do you have any workaround for this? I looked through the dependabot configuration and couldn't really find anything. I have not looked at alternatives (such as renovate), maybe they support this better, but I was hoping for a quick fix.

How do you deal with it for your own projects?

@sunshowers
Copy link
Member

Hi, thanks for the issue! This is definitely an unfortunate wart with hakari, and I don't know of a way to handle this within Dependabot.

For this repo, and at my workplace (Oxide), we switched to Renovate partly for this reason.

The configs are:

I would eventually like hakari to go away, if and when Rust RFC 3692 becomes stabilized.

@VorpalBlade
Copy link
Author

Thanks, I'll have to put learning renovate on my todo list I guess.

@VorpalBlade
Copy link
Author

Since you otherwise have such excellent docs on how to use hakari and best practises: might I suggest adding a short note about this there? Probably under the "Making hakari work well" heading?

@sunshowers
Copy link
Member

Agreed, that would be good. Would you like to submit a PR? Otherwise I'll probably get to this in the next couple of weeks.

@VorpalBlade
Copy link
Author

I'll make no promises as to what I have the time or energy to work on when it comes to open source. So if I haven't made a PR when you get around to it: go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants