-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo hakari misses some dependencies/features #73
Comments
Adding |
Hi, could you follow the instructions here to add the platforms you use? https://docs.rs/cargo-hakari/latest/cargo_hakari/config/index.html#platforms By default, hakari doesn't try to unify platform-specific dependencies. It will do so if you list out platforms in that section. |
Oh indeed, it works better with platforms... it's a little inconvenient, though. I'll note that it's not really clear from the doc that this is the expected outcome. I mean, your comment makes it clear, but the doc doesn't really. |
Yeah, I agree. Would you like to submit a change to the docs regarding this? Would be greatly appreciated! |
Steps to reproduce:
Cargo.toml
file with the following content:a/Cargo.toml
add the following content after[dependencies]
:b/Cargo.toml
add the following content after[dependencies]
:Expected result:
My understanding of what hakari is meant to do is that
winapi
should be built only once.Actual result:
It is built twice, because the workspace hack doesn't contain the common features for
winapi
.The text was updated successfully, but these errors were encountered: