Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only foreground censor clustered triggers, not pre-cluster ones #4923

Open
tdent opened this issue Nov 4, 2024 · 0 comments
Open

Only foreground censor clustered triggers, not pre-cluster ones #4923

tdent opened this issue Nov 4, 2024 · 0 comments
Assignees

Comments

@tdent
Copy link
Contributor

tdent commented Nov 4, 2024

In pycbc_coinc_statmap, it seems like an error to make foreground censor veto windows on events before clustering zerolag (https://github.com/gwastro/pycbc/blob/master/bin/all_sky_search/pycbc_coinc_statmap#L142).

At least, since the pre-clustered events are not visible and not part of any results there doesn't seem to be any reason to veto their times, and it risks significantly (and spuriously) reducing the remaining time available for injections to be searched.

@tdent tdent assigned ahnitz and tdent Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants