Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single IFO SNR cut #4980

Open
pannarale opened this issue Dec 9, 2024 · 2 comments
Open

Single IFO SNR cut #4980

pannarale opened this issue Dec 9, 2024 · 2 comments

Comments

@pannarale
Copy link
Contributor

Currently, pycbc_multi_inspiral applies the sngl_snr_threshold (when there is more than 1 IFO) by requiring the threshold to be exceeded in at least 2 IFOs

  • It is hard-coded here and you get to that line from here.
  • If I recall correctly, the old code used to apply the cut in the two most sensitive IFOs, when more than 2 IFOs were present in the worfklow.

I don't think I mind dropping "most sensitive" (sensitivity does not imply being more/less glitchy) but we should apply the cut only with 3 or more IFOs.
@pannarale pannarale moved this to In Progress in PyGRB Development Dec 9, 2024
@titodalcanton
Copy link
Contributor

This is an optimization choice, trading computing cost for sensitivity. I should review my own thesis on this, but perhaps it would be better to do some measurements of cost vs threshold method?

@titodalcanton
Copy link
Contributor

@spxiwh probably has something to say on this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
PyGRB Development
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@titodalcanton @pannarale