Fix check for pegasus-plan
#4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarethCabournDavies
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Pegasus is not installed, planning a workflow will give you a weird error. This makes it give a better error.
Standard information about the request
This is a bug fix.
This change affects anything based on Pegasus workflows.
Motivation
The old code would give you this error:
and then postdocs and students would ask me what is happening, and I would have to investigate and find out that the cause was a trivial mistake on my end.
With this PR I can skip the "investigate" part.
Contents
Catch the case when
pegasus-planis not available and print out an explicit message.Links to any issues or associated PRs
N/A
Testing performed
None.
Additional notes
:unicorn_face: