New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new "keep" option instead of "strip" option #467

Open

james-johnston-thumbtack opened this issue Feb 3, 2024 · 0 comments

james-johnston-thumbtack commented Feb 3, 2024

It looks like the "strip" option used by bimg here:

Lines 327 to 333 in ee92010

    
           return vips_jpegsave_buffer(in, buf, len, 
        
           	"strip", INT_TO_GBOOLEAN(strip), 
        
           	"Q", quality, 
        
           	"optimize_coding", TRUE, 
        
           	"interlace", INT_TO_GBOOLEAN(interlace), 
        
           	NULL 
        
           );

Was recently deprecated and replaced with a new "keep" option: libvips/libvips@32ddfe7#diff-0cdb749283812170ac7d97de48ef99c912116600da659cc717b249eecc350151

It looks like the old "strip" flag is still supported.... for now:
https://github.com/libvips/libvips/blob/4cb9da6248e8134050aea7c4adc5d696f5d399d9/libvips/foreign/foreign.c#L1789-L1795

It seems that bimg could consider supporting the new "keep" option for libvips versions that support it.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment