Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h5peditor-select.js - make selected option criteria more flexible #102

Open
chwatts opened this issue Jun 16, 2021 · 0 comments
Open

h5peditor-select.js - make selected option criteria more flexible #102

chwatts opened this issue Jun 16, 2021 · 0 comments

Comments

@chwatts
Copy link

chwatts commented Jun 16, 2021

Line 90 in h5peditor-select.js is this:

html += E.createOption(options[i].value, options[i].label, options[i].value === selected);

I would like to make a simple change to turn === into the more flexible ==, as I have a few cases where the correct option is not selected.

html += E.createOption(options[i].value, options[i].label, options[i].value == selected);

If you agree I will create the simple pull request. Kind regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant