Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFRAME embed code requires additional attributes #59

Open
pjotrsavitski opened this issue Apr 12, 2019 · 0 comments
Open

IFRAME embed code requires additional attributes #59

pjotrsavitski opened this issue Apr 12, 2019 · 0 comments

Comments

@pjotrsavitski
Copy link

It seems that browsers have made changes what sort of APIs are allowed to be used from within an <iframe>. Disabling everything by default as described here.

This in term raises issues with any H5P type that requires usage of certain API's. The one that allows user to use a microphone and save the result as a file fails dues to that when being embedded. The error shown to the enduser is Access to microphone is not allowed due to page not being loaded using HTTPS (current working is not 100% correct but is something along those lines.

Chrome itself shown no errors or warning in the developer console, though Safari does mention that getUserMedia was called from a frame without correct 'allow' attribute.

The solution for this case is simple enough, adding allow="microphone; midi" to the iframe code. It might not be enough to cover the needs for all of the H5P content types (either current or one that could be created in future). Using allow="*" would allow everything and from any context. yet that could be considered a bit too permissive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant