Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing on next release? #82

Open
cosmicdreams opened this issue Apr 2, 2020 · 1 comment
Open

Timing on next release? #82

cosmicdreams opened this issue Apr 2, 2020 · 1 comment

Comments

@cosmicdreams
Copy link

Hey gang:

I've been trying to hunt down the source of a series of PHP Warnings I get that targets the h5p.classes.php file of the H5p dependency. The warning I get is:

PHP Deprecated: Array and string offset access syntax with curly braces is deprecated in /vendor/h5p/h5p-core/h5p.classes.php on line 2747

Deprecated: Array and string offset access syntax with curly braces is deprecated in /vendor/h5p/h5p-core/h5p.classes.php on line 2747

Where is my site's directory.

I was able to track this warning's root cause down to how it works with PHP 7.4. This warning appears to have been patched last year:
https://github.com/h5p/h5p-php-library/commits?author=stronk7

However, that fix was not included in the 1.24.0 release, but it is in master.

I'm hoping that you can cut a 1.24.1 so I can get rid of this nuisance.

@heddn
Copy link

heddn commented Oct 21, 2020

+1 on a new release. PHP 7.4 has been out for some time. And 8.0 is about to be released in a few short weeks. Let's get something release, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants