Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document PHP version requirement #9

Open
juho-jaakkola opened this issue Dec 4, 2015 · 5 comments
Open

Document PHP version requirement #9

juho-jaakkola opened this issue Dec 4, 2015 · 5 comments

Comments

@juho-jaakkola
Copy link
Contributor

Currently there is no information of the required PHP version.

Make sure to add it at least to the require section in composer.json, for example:

{
    "require" : {
        "php" : "^5.5"
    }
}

This way composer automatically checks the version when the library is being installed to a project.

@icc
Copy link
Member

icc commented Jan 4, 2016

The original target version was 5.2.5 or higher. I guess we should keep that as long as we support Drupal 6.

@juho-jaakkola
Copy link
Contributor Author

PHP 5.2? Ouch, support for it ended already in 2011. This further reaffirms my thought that the project would benefit from using Semver-compatible branches for different versions. I added #12 for further discussion.

@Tuurlijk
Copy link

On February 24th 2016, Drupal 6 will reach end of life and no longer be supported.

https://www.drupal.org/forum/general/news-and-announcements/2015-11-09/drupal-6-end-of-life-announcement

Can we please move on here? The library needs some refactoring and polish.

@djoudi
Copy link

djoudi commented Aug 11, 2019

i think is realy to upgrade to php 7.*

@otacke
Copy link
Contributor

otacke commented Aug 11, 2019

@djoudi I think @fnoks tried to explain why 5.3 is still set as a minimum requirement at #64 (comment) just three weeks ago.

thomasmars pushed a commit that referenced this issue Nov 4, 2021
JI-2755 Change height of bottom bar back to 25px
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants