Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot remove upload image in Gallery #170

Open
SiboYang opened this issue Apr 3, 2021 · 3 comments
Open

Cannot remove upload image in Gallery #170

SiboYang opened this issue Apr 3, 2021 · 3 comments
Assignees
@SiboYang
Labels
bug Something isn't working frontend React, Material UI

Comments

@SiboYang
Copy link
Member

SiboYang commented Apr 3, 2021

Current remove handler in imageUpload only removes the image from firebase storage, it doesn't remove the image from our database.
@SiboYang SiboYang self-assigned this Apr 3, 2021
@SiboYang SiboYang added bug Something isn't working frontend React, Material UI labels Apr 3, 2021
@tedspare
Copy link
Member

tedspare commented Apr 3, 2021

Could this be related to #167? Have you been deleting lots of images? 😂

@SiboYang
Copy link
Member Author

SiboYang commented Apr 3, 2021 •
edited
Loading

Could this be related to #167? Have you been deleting lots of images? 😂

lol, I guess they are not related, I didn't delete any image, this bug is just something I suddenly realized that I missed when looking at the code I wrote before.

#167 is really weird... I am very confused even after checking the code...

@tedspare
Copy link
Member

tedspare commented Apr 3, 2021 •
edited
Loading

Could this be related to #167? Have you been deleting lots of images? 😂

lol, I guess they are not related, I didn't delete any image, this bug is just something I suddenly realized that I missed when looking at the code I wrote before.

#167 is really weird... I am very confused even after checking the code...

Okay! Thanks for checking. Me too - I double-checked the Firebase Storage security rules and they're legit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SiboYang SiboYang

Labels
bug Something isn't working frontend React, Material UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tedspare @SiboYang