Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create guideline for documenting clarifications #182

Open
11 tasks
fyliu opened this issue Aug 13, 2023 · 1 comment
Open
11 tasks

Create guideline for documenting clarifications #182

fyliu opened this issue Aug 13, 2023 · 1 comment
Labels
complexity: missing feature: docs: team guide Same as PD team documentation? feature: DR this issue contains info that should be written into/or update abDecision Record (DR) feature: process improvement p-feature: sponsor/partner ready for dev lead role: dev lead role: technical writing s: PD team stakeholder: People Depot Team size: 3pt Can be done in 13-18 hours

Comments

@fyliu
Copy link
Member

fyliu commented Aug 13, 2023

Dependency

Overview

We would like to come up with a guideline for where to put clarifying documentation in the code so that it's helpful for people maintaining it and using it.

Details

We can use issue #162 which has clarifying information about sponsors and partners that's not obvious which makes it more important to be documented.
We can use the diataxis structure for documentation to create Reference docs for the models and APIs and Explanation docs for the sponsor/partner concept.

Action Items

  • For sponsor_partner Reference
    • Add docstring to the model
    • Add docstring to the API code
    • Add markdown reference for the is_org_sponsor and is_org_partner fields
  • For project_partner_xref Reference
    • Add docstring to the model
    • Add docstring to the API code
    • Add markdown reference for the is_sponsor field
  • Write markdown Explanation docs to explain sponsor/partner at a high level
  • Discuss in a comment below which one(s) are better / more useful
  • Write a guideline or ADR for what to do and why

Resources/Instructions

Sponsor/Partner clarification (copied from #65)

Sponsor/partner relationships stored in this table are project-dependent. They cannot be both a sponsor and a partner for the same project, so if is_sponsor is FALSE they are a project partner, if is_sponsor is TRUE they are a project sponsor.

Project vs Org level clarification (copied from #65)

... sponsor/partner relationships are project-dependent, so is_sponsor stays in this table. They cannot be both a sponsor and a partner for the same project. In addition, they can also be a sponsor or partner at the org level, so the levels are:

  • project partner
  • project sponsor
  • org partner
  • org sponsor

Org level sponsors and partners (copied from #162)

There can be sponsors or partners at the org level as well as for individual projects. The same entity cannot be both a sponsor and a partner for a single project, but can be both a sponsor and a partner to the organization itself.

@fyliu fyliu added the draft This issue is not fully-written label Aug 13, 2023
@fyliu fyliu added size: 2pt Can be done in 7-12 hours feature: process improvement p-feature: sponsor/partner s: PD team stakeholder: People Depot Team role: technical writing feature: docs: PD team documentation documentation on PD team processes and architecture, etc. feature: DR this issue contains info that should be written into/or update abDecision Record (DR) labels Aug 13, 2023
@fyliu fyliu added this to the v0.01 - initial setup milestone Aug 13, 2023
@fyliu fyliu removed the draft This issue is not fully-written label Aug 13, 2023
@fyliu fyliu changed the title We should start documenting model Create guideline for documenting clarifications Aug 13, 2023
@fyliu fyliu added size: 3pt Can be done in 13-18 hours role: db architect dependency Issue has dependencies and removed size: 2pt Can be done in 7-12 hours labels Aug 13, 2023
@fyliu
Copy link
Member Author

fyliu commented Aug 14, 2023

I added #162 as a dependency. It has a more complete high-level discussion of how sponsors and partners work in the system. This can become a docs page about "Sponsors and Partners" which explains what an external entities can become sponsors and partners of. It would be helpful if it can contain links to the Reference docs for the 2 models which provide definitions of the model fields. And those model docs can reference the Explanation page.

This was referenced Aug 14, 2023
@fyliu fyliu added feature: docs: team guide Same as PD team documentation? and removed feature: docs: PD team documentation documentation on PD team processes and architecture, etc. labels Jun 3, 2024
@shmonks shmonks moved this to Ice Box in P: PD: Project Board Jun 7, 2024
@ExperimentsInHonesty ExperimentsInHonesty added complexity: missing and removed dependency Issue has dependencies labels Jun 21, 2024
@shmonks shmonks added the dependency Issue has dependencies label Sep 20, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this from 🧊Ice Box to 🆕New Issue Review in P: PD: Project Board Oct 7, 2024
@ExperimentsInHonesty ExperimentsInHonesty removed the dependency Issue has dependencies label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: missing feature: docs: team guide Same as PD team documentation? feature: DR this issue contains info that should be written into/or update abDecision Record (DR) feature: process improvement p-feature: sponsor/partner ready for dev lead role: dev lead role: technical writing s: PD team stakeholder: People Depot Team size: 3pt Can be done in 13-18 hours
Projects
Status: 🆕New Issue Review
Development

No branches or pull requests

3 participants