Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test field level permissions #274

Open
2 of 3 tasks
anandramakris opened this issue Apr 5, 2024 · 9 comments
Open
2 of 3 tasks

Test field level permissions #274

anandramakris opened this issue Apr 5, 2024 · 9 comments
Labels
complexity: large Many parts are unexplained and up to the implementer to figure out. dependency Issue has dependencies draft This issue is not fully-written ethan p-feature: permissions p-feature: program area all projects have a program area. the CoPs's program area is CoP p-feature: projects project and projects p-feature: user role: back end s: PD team stakeholder: People Depot Team size: 8pt Can be done in 31-48 hours

Comments

@anandramakris
Copy link
Member

anandramakris commented Apr 5, 2024

Overview

We are planning on including field-level security for tables. The required permissions need to be tested before implementation.

Action Items

  • implement code needed for FLS (tables, possibly models)
    • create tables
    • add test data
  • test Practice Lead project
  • create test cases for FLS

Resources/Instructions

@ExperimentsInHonesty
Copy link
Member

@anandramakris, @Neecolaa and I just finished writing - Use cases and tests for FLS feasibility: #150 (comment), and we have added the link to this comment above under Resources. Let us know in a comment here if you have any questions.

@anandramakris
Copy link
Member Author

anandramakris commented May 2, 2024

@ExperimentsInHonesty
Copy link
Member

@anandramakris and what was the outcome?

Last time we spoke you were going to setup the data and then feed ChatGPT the prompt with the data so that it could provide a more complete solution. Did you try that, and if so, please cut and past the conversation into this issue.

@anandramakris
Copy link
Member Author

anandramakris commented May 3, 2024

Had forgotten to try it, so I did it first thing this morning.

Attached is a link to the chat, in which I asked in order about:

  1. Testing the classes,
  2. Using pytest with the data,
  3. Specifically testing each value of PermissionType.
    test-permissions.pdf

@ExperimentsInHonesty
Copy link
Member

@anandramakris Please provide update

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

@anandramakris anandramakris removed their assignment May 10, 2024
@anandramakris
Copy link
Member Author

anandramakris commented May 10, 2024

Asked ChatGPT about field-level permissions in Django, giving the test cases for memberGeneral and memberProject as a basic prompt. Result is attached as pdf.
django-fieldpermissions.pdf

Note: the transcript is in pdf becasue the original html file is not accepted by github.

@ExperimentsInHonesty
Copy link
Member

@ethanstrominger Please do a draft PR, we need to see the file permissions (how they show up in the models) so that we can revise our documentation on who should have which permissions.

@shmonks shmonks added the draft This issue is not fully-written label Sep 27, 2024
@shmonks shmonks moved this from 🏗In progress (actively working) to 📋Prioritized Backlog in P: PD: Project Board Sep 27, 2024
@shmonks shmonks moved this from 📋Prioritized Backlog to 🆕New Issue Review in P: PD: Project Board Sep 27, 2024
@ethanstrominger ethanstrominger moved this from 🆕New Issue Review to 🧊Ice Box in P: PD: Project Board Sep 30, 2024
@ethanstrominger ethanstrominger removed their assignment Sep 30, 2024
@ethanstrominger
Copy link
Member

ethanstrominger commented Sep 30, 2024

Moved to ice box so that work on #331 can inform the documentation - the documentation that is written for #331 might be sufficient. The implementation of #331 will include testing of everything implemented.

@ethanstrominger ethanstrominger added complexity: large Many parts are unexplained and up to the implementer to figure out. ethan and removed complexity: x-large labels Oct 1, 2024
@shmonks shmonks added the dependency Issue has dependencies label Oct 24, 2024
@ethanstrominger
Copy link
Member

Bonnie/Ethan: discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: large Many parts are unexplained and up to the implementer to figure out. dependency Issue has dependencies draft This issue is not fully-written ethan p-feature: permissions p-feature: program area all projects have a program area. the CoPs's program area is CoP p-feature: projects project and projects p-feature: user role: back end s: PD team stakeholder: People Depot Team size: 8pt Can be done in 31-48 hours
Projects
Status: ❓Questions/Review
Development

No branches or pull requests

4 participants