Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Insight] Symfony controller action method should not be too long #100

Open
hackzilla opened this issue Nov 28, 2016 · 2 comments
Open

[Insight] Symfony controller action method should not be too long #100

hackzilla opened this issue Nov 28, 2016 · 2 comments

Comments

@hackzilla
Copy link
Collaborator

15% of all actions have more than 20 lines. This violation is raised when more than 10% actions are too long.


Posted from SensioLabsInsight

@bubnov-mikhail
Copy link

We could do this in all actions:

if (!$ticket = $ticketManager->getTicketById($ticketId)) { throw .....; }

@hackzilla
Copy link
Collaborator Author

as much as I'm tempted, the Coding Style will moan.

I was thinking separate Controllers for each bit.
It's been something I've been trying to fix for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants