Replace implementations for auto. derived impl Clone, Debug (& more?)
#108
Comments
bors bot
added a commit
that referenced
this issue
Jun 5, 2023
106: Add support for attributes & expn_data on items (fixes #49, fixes #88) r=franziskuskiefer a=W95Psp This also makes #45 trivial to implement ~This is draft because I removed the quick & dirty filter implemented in #94, thus I now need to restore the functionality.~ - ~[ ] when we see an `impl` for a `Clone` derived by `core::clone::Clone`, replace it with an identity impl~ - ~[ ] when we see an `impl` for a `Debug` derived by `core::fmt::macros::Debug`, replace it with a dummy impl (e.g. a constant string)~ I restored a filter similar to what I did in #94: we skip every automatically_dervied items. Issue #108 keeps track of the progress on writing a better filter, so that this PR is smaller. Co-authored-by: Lucas Franceschino <[email protected]>
bors bot
added a commit
that referenced
this issue
Jun 6, 2023
106: Add support for attributes & expn_data on items (fixes #49, fixes #88) r=W95Psp a=W95Psp This also makes #45 trivial to implement ~This is draft because I removed the quick & dirty filter implemented in #94, thus I now need to restore the functionality.~ - ~[ ] when we see an `impl` for a `Clone` derived by `core::clone::Clone`, replace it with an identity impl~ - ~[ ] when we see an `impl` for a `Debug` derived by `core::fmt::macros::Debug`, replace it with a dummy impl (e.g. a constant string)~ I restored a filter similar to what I did in #94: we skip every automatically_dervied items. Issue #108 keeps track of the progress on writing a better filter, so that this PR is smaller. Co-authored-by: Lucas Franceschino <[email protected]>
|
This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days. |
|
This issue has been closed due to a lack of activity since being marked as stale. If you believe this issue is still relevant, please reopen it with an update or comment. |
|
In most cases, we only need these derived impls in interfaces, so a potential solution may be to implement #1028 |
|
This is related to #1113. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
implfor aClonederived bycore::clone::Clone, replace it with an identity implimplfor aDebugderived bycore::fmt::macros::Debug, replace it with a dummy impl (e.g. a constant string)Such transformations should be a user setting, both in the CLI and Cargo.toml, see #248.
This setting could be a list of rules for rewriting a matching block of code with another (possibly empty) block of code.
For now, we just drop the automatically derived impl blocks.
The text was updated successfully, but these errors were encountered: