Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix renaming of trait method in bundling. #1126

Closed
wants to merge 1 commit into from
Closed

Fix renaming of trait method in bundling. #1126

wants to merge 1 commit into from

Conversation

maximebuyse
Copy link
Contributor

Fixes #1124

@W95Psp
Copy link
Collaborator

W95Psp commented Nov 25, 2024

Thanks, I'm looking at it now

@maximebuyse
Copy link
Contributor Author

Thanks, I'm looking at it now

Thanks, I just realized that we already had a PR and an issue for the exact same problem...

@W95Psp
Copy link
Collaborator

W95Psp commented Nov 25, 2024 •
edited
Loading

Oh. That's pretty bad.
Since we saw that during the offsite week, I guess we were trying to do things too fast there.

We should have noticed #1124 was a duplicate.

I'm trying to test thoroughly the renaming, and I am finding more bugs.

Let's chat to come up with a plan (sent you an invite).
We need to redesign a bit things to come up with something more robust.

Note: https://gist.github.com/hax-playground/0ba7f91359afb8f4013bec2611270738 is a draft set of tests for testing the renamings.

@franziskuskiefer franziskuskiefer mentioned this pull request Nov 28, 2024
Open
@maximebuyse
Copy link
Contributor Author

Closing in favor of #1075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp Awaiting requested review from W95Psp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cyclic dependency with trait impl
2 participants
@maximebuyse @W95Psp