Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporter: document clause_id whenever it appears #626

Closed
W95Psp opened this issue Apr 24, 2024 · 3 comments
Closed

Exporter: document clause_id whenever it appears #626

W95Psp opened this issue Apr 24, 2024 · 3 comments
Labels
frontend Issue in the Rust to JSON translation

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Apr 24, 2024

No description provided.

@W95Psp W95Psp added the frontend Issue in the Rust to JSON translation label Apr 24, 2024
@Nadrieril
Copy link
Collaborator

Nadrieril commented Apr 24, 2024 •
edited
Loading

I'd also suggest using a newtype wrapper instead of a bare u64 to make it easier to see what APIs relate to this identifier

@W95Psp
Copy link
Collaborator Author

W95Psp commented Apr 24, 2024

Ah yeah, that would be more clear indeed, thanks!

@W95Psp W95Psp mentioned this issue May 13, 2024
Closed
@W95Psp
Copy link
Collaborator Author

W95Psp commented May 16, 2024

This was closed by #662

@W95Psp W95Psp closed this as completed May 16, 2024
@github-project-automation github-project-automation bot moved this to Done in hax May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Issue in the Rust to JSON translation
Projects
No open projects
hax
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@W95Psp @Nadrieril