-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aes
crate: the frontend loops indefinitely
#686
Comments
I think this is related: |
Strangely enough, PR #730 doesn't fix this issue but fixes the looping behavior in |
This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days. |
This is still a problem, a759a1a doesn't help |
Still there after #970 |
@Nadrieril mostly fixed the bug with its PR #996! This pseudo-loop was hiding another bug; I have a fix, will push a PR soon. But the aes crate now extract in under 40 seconds! Thanks @Nadrieril! |
Let's close this. The extraction now works: the extraction itself takes around 40s, but the haxmeta/JSON business takes around 4 minutes on my laptop... Let's see how we can improve that: |
To reproduce, clone https://github.com/RustCrypto/block-ciphers at commit ae1892c8, and
cargo hax json
on crateaes
.This behavior is the same for libsignal, which uses the crate
aes
.@franziskuskiefer and I looked at it a bit yesterday (with
RUST_LOG=trace cargo hax json
, hax being compiled in debug mode), and it seems like someSized
trait obligations are resolved a HUGE number of times before killing the memory of the laptop it's running on.So probably there is somehow an infinite recursion or loop, but that definitively has to do with trait resolution.
Ccing @Nadrieril who had a very very similar issue a few weeks ago
The text was updated successfully, but these errors were encountered: