Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hax-lib optional even when using trait and impl #886

Closed
karthikbhargavan opened this issue Sep 12, 2024 · 1 comment · Fixed by #983
Closed

Make hax-lib optional even when using trait and impl #886

karthikbhargavan opened this issue Sep 12, 2024 · 1 comment · Fixed by #983
Assignees

Comments

@karthikbhargavan
Copy link
Contributor

The recommended style for projects using hax is to make the dependence on hax-lib optional by guarding all uses of hax attributes with cfg_attr(hax, ...). However, this does not work with the hax_lib::attributes macro that we put on trait and impl. We should try to find a solution that works in this case as well.

@W95Psp
Copy link
Collaborator

W95Psp commented Oct 14, 2024

This will be fixed by:

@W95Psp W95Psp linked a pull request Oct 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants