fix(engine/dune): disable js build by default #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franziskuskiefer
requested changes
Feb 19, 2024
W95Psp
added
the
waiting-on-author
W95Psp
force-pushed
the
disable-js-build
branch
3 times, most recently
from
6a4297b to
08e430e
Compare
W95Psp
removed
the
waiting-on-author
franziskuskiefer
approved these changes
May 7, 2024
|
@W95Psp Looks like js build is failing https://github.com/hacspec/hax/actions/runs/9058340703/job/24883799618 |
|
Oh, I know why... pushing a fix soon Thanks for noticing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the dune JS build of the engine by default.
For now, this build is never used.