Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include main branch #518

Closed
wants to merge 1 commit into from
Closed

include main branch #518

wants to merge 1 commit into from

Conversation

wibeasley
Copy link

to help people using this yaml file as a starting point in a new GitHub repo

to help people using this yaml file as a starting point in a new GitHub repo
@hadley
Copy link
Owner

hadley commented Oct 11, 2021

Thanks for working on this but we’re going to tackle globally in #512

@hadley hadley closed this Oct 11, 2021
@wibeasley
Copy link
Author

#512 seems similar, but not quite the same. It's talking about moving this specific repo from master to main, right?

This change is focused on people using Mastering Shiny as a starting point for their bs4_book build, as advocated in the current bookdown book section 3.1.2 Three-column Bootstrap style

The bs4_book() output format is built with Bootstrap ... You can read an example book here: https://mastering-shiny.org

I'm basically updating this workflow yaml so it's consistent will the ones I've seen @jimhester use since GitHub started advocating the main branch a year ago. https://github.com/tidyverse/readr/blob/7ded0b0f0f39e8429163e9467f3c727b28036c8c/.github/workflows/pkgdown.yaml#L1-L5

@hadley
Copy link
Owner

hadley commented Oct 12, 2021

It’s all part of the same general problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants