Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vulkan] Evaluate SDK dependency for AOT generators #7235

Closed
derek-gerstmann opened this issue Dec 13, 2022 · 1 comment · Fixed by #8452
Closed

[vulkan] Evaluate SDK dependency for AOT generators #7235

derek-gerstmann opened this issue Dec 13, 2022 · 1 comment · Fixed by #8452

Comments

@derek-gerstmann
Copy link
Contributor

This is largely an unfortunate packaging issue on Windows where the CMake infrastructure for Vulkan expects to find the Vulkan headers (which we don't need), as well as the Vulkan loader library (which is needed for linking), all of which are packaged up in the SDK. So installing the SDK is the easiest solution, but not ideal and creates another dependency that we don't need.

Unfortunately, this may mean adding a custom CMake FindVulkan method that simply locates the path to the loader library to configure a proper environment for AOT tests and apps.

@derek-gerstmann
Copy link
Contributor Author

Resolved in #8452. We now reference the official headers, and use CMAKE find package rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant