Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up project #34

Open
skjolber opened this issue Apr 11, 2020 · 2 comments
Open

Tidy up project #34

skjolber opened this issue Apr 11, 2020 · 2 comments

Comments

@skjolber
Copy link

This is a very good utility project, however it could need some polish / tidying up:

  • close old and finished project issues, add documentations where applicable (thread safety?)
  • fix builder pattern
    • return instance from builder
    • must the build(Map) be a TreeMap?
  • use protected methods instead of private (to be consistent with field access)
  • move inner classes, interfaces to seperate types
    • possibly tie search type to builder
  • no public fields
  • remove object input / output stream, or at least move to seperate class
    • why read/write fields instead of full class?
  • nuke commented-out code
  • add code coverage maven plugins (currently at 72%), i.e. jacoco
  • add github integrations for security patches (i.e. snyk etc)
  • add github integrations for code quality, fix flagged issues
  • add JMH module for proper performance comparisons
@Euraxluo
Copy link

you can build a maven project.that is clean code

@skjolber
Copy link
Author

you can build a maven project.that is clean code

Your statement does not make much sense, can you explain in more detail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants