Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing message IDs #1792

Open
dotasek opened this issue Oct 28, 2024 · 1 comment
Open

Missing message IDs #1792

dotasek opened this issue Oct 28, 2024 · 1 comment
Labels
bug Something isn't working validation-core

Comments

@dotasek
Copy link
Collaborator

dotasek commented Oct 28, 2024

It looks like there are a few places in BaseValidator where there is a msg constant available that isn't passed along as the message id:

addValidationMessage(errors, ruleDate, type, -1, -1, path, message, IssueSeverity.WARNING, null);

Is there a legitimate reason this isn't being passed along, or is this a mistake?

@grahamegrieve
Copy link
Collaborator

That one is a mistake. They might not all be mistakes though

@dotasek dotasek added bug Something isn't working validation-core labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validation-core
Projects
None yet
Development

No branches or pull requests

2 participants