Type information for client constructor incorrect

[dominykas]

Runtime

node.js

Runtime version

v20/v22

Module version

v14

Last module version without issue

No response

Used with

No response

Any other relevant information

https://github.com/hapijs/nes/blob/master/lib/client.d.ts#L176 - options.ws for the constructor are declared as a string, but ws package actually accepts an object.

Might open a PR myself later.

What are you trying to achieve or the steps to reproduce?

new Client(url, { ws: { origin } })

What was the result you got?

Argument type {ws: {origin: string}} is not assignable to parameter type {ws?: string | string[], timeout?: number | boolean} | undefined

What result did you expect?

Things to actually work (since there's no actual change in the code since v13 anyways).

[damusix]

Hey thanks for pointing this out. These types were ported from DTS and not everything might have been caught. If you find more, report it. I'll fix it ASAP.