Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename images file name for privacy and security chapter figures #479

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

AbenezerKb
Copy link
Contributor

@AbenezerKb AbenezerKb commented Oct 23, 2024

Before submitting your Pull Request, please review and complete the items on this checklist.

  • The text has been proofread for grammar and spelling errors.
  • All images, figures, and tables render properly without any glitches.
  • All images have a source or they are properly linked to external sites.
  • The chapter's formatting is consistent with the rest of the book.
  • The chapter has been locally built and tested using Quarto.

@profvjreddi
Copy link
Contributor

Hi @AbenezerKb,

Thank you for taking the time to provide these fixes. I'm not sure if you're aware, but this was one of the issues I was hoping we could address, as listed here: #479.

So I really appreciate your help and the effort you put into this. Thank you once again!

@profvjreddi profvjreddi merged commit 0c3ca94 into harvard-edge:dev Oct 25, 2024
3 checks passed
@profvjreddi
Copy link
Contributor

I merged it in @AbenezerKb -- when I push the latest updates to the live book version then you will appear in the contrib : )

@profvjreddi profvjreddi added the maintainence quarto/git bookkeeping label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainence quarto/git bookkeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants