Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags vs tags_list #26

Open
charlescva opened this issue Sep 3, 2019 · 0 comments
Open

tags vs tags_list #26

charlescva opened this issue Sep 3, 2019 · 0 comments

Comments

@charlescva
Copy link

charlescva commented Sep 3, 2019

variable "tags_list" {

I have used the vault-best-practices/operations/provisioning for AWS as a starting point and have been looking to upgrade it (and subsequent modules) to align with 0.12. (0.11 works well)

As you already know, in 0.12 there are reserved variables, for-loops, if statements, and various other changes regarding input variable types and how they are interpreted. I see "TODOs" in the comments.

One change I am trying to understand is rational behind supporting the use of ec2 instance tags?

What is the use of having a list(string) or "tags_list" and map(string) "tags" in consul-aws? Is this just to support re-use in parent projects that may have either? The descriptions are the same, so I'm wondering if vault best practices actually uses them or both in some way?

@bensojona This is more of a general question than a bug/feature needing a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant