Time - component (HDS-3945)
#2515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KristinLBradley
force-pushed
the
hds-3945-date-time-display
branch
from
880c9b4
to
725c1b4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
KristinLBradley
commented
Oct 29, 2024
…s, update return value
…erations and update tests
…hout tooltip, add more examples to Showcase
Co-authored-by: Lee White <[email protected]>
KristinLBradley
force-pushed
the
hds-3945-date-time-display
branch
from
4da833a
to
d0012b4
Compare
KristinLBradley
commented
Nov 27, 2024
|
|
||
| .hds-time-range { | ||
| display: inline-flex; // remove excess space between time range elements | ||
| gap: 2px; // add a bit of space around en dash so it doesn't touch some number characters |
There was a problem hiding this comment.
@majedelass I added just a bit of spacing around the en dashes in date ranges to prevent them from actually touching text. I don't have a way of adding the same spacing within tooltip content however as those use only plain text (no html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will add the
Timecomponent and service to HDS.Showcase: https://hds-showcase-git-hds-3945-date-time-display-hashicorp.vercel.app/components/time
Documentation branch:
Time- docs (HDS-4161) #2557🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.