-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website: create new content section #2572
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of minor comments.
@@ -43,10 +43,6 @@ | |||
padding: 0 24px; | |||
color: var(--doc-color-white); | |||
background: var(--doc-color-black); | |||
|
|||
@include breakpoint.with-fixed-sidebar() { | |||
gap: 32px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gap between the header and the edge of the page is always 24px now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -139,75 +135,35 @@ | |||
} | |||
} | |||
|
|||
.doc-page-header__nav-item-generic { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that @dchyun!! it should be better now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment about the space between the logo (Helios Design System) and the nav links. From what I could tell, that was it! Nice work :D
📌 Summary
If merged, this PR would
📸 Screenshots
🔗 External links
Jira ticket: HDS-4159
Jira ticket: HDS-4158
Figma file: https://www.figma.com/design/ZlIlup8HxCOlQLXRwv56In/HDS-Content-Guidelines?node-id=119-3584&node-type=canvas&t=cyilBmJA92W2EKn5-0
💬 Please consider using conventional comments when reviewing this PR.