Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: create new content section #2572

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

shleewhite
Copy link
Contributor

@shleewhite shleewhite commented Nov 19, 2024

📌 Summary

If merged, this PR would

  • update the main website navigation
    • reorder the items in the top nav and the sidebar
    • add new content section
    • change the design for search, support items
    • add content section to sidebar
  • create stub pages for voice and tone and writing for ui copy

📸 Screenshots

Screenshot 2024-11-19 at 9 58 06 AM

🔗 External links

Jira ticket: HDS-4159
Jira ticket: HDS-4158
Figma file: https://www.figma.com/design/ZlIlup8HxCOlQLXRwv56In/HDS-Content-Guidelines?node-id=119-3584&node-type=canvas&t=cyilBmJA92W2EKn5-0


💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Nov 22, 2024 6:28pm
hds-website ✅ Ready (Inspect) Visit Preview Nov 22, 2024 6:28pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Nov 19, 2024
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor comments.

website/app/styles/pages/application/header.scss Outdated Show resolved Hide resolved
@dchyun
Copy link
Contributor

dchyun commented Nov 21, 2024

Small thing, but in the mobile menu, looks like the spacing between the two icons, and between the menu and the edge of the screen are a bit tighter in the figma.

Figma

Screenshot 2024-11-21 at 10 28 05 AM

Current UI

Screenshot 2024-11-21 at 10 28 15 AM

@@ -43,10 +43,6 @@
padding: 0 24px;
color: var(--doc-color-white);
background: var(--doc-color-black);

@include breakpoint.with-fixed-sidebar() {
gap: 32px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gap between the header and the edge of the page is always 24px now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reduced the space between the logo and the nav links to being 16px always, which I think we don't want to do (it's too tight right now).
image

I think removing this is removing essentially this?
image

@@ -139,75 +135,35 @@
}
}

.doc-page-header__nav-item-generic {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These styles were only affecting the support icon link and the github link and the only thing they did were add display block and make the focus ring look way thicker than the other nav items' focus states.

Screenshot 2024-11-21 at 11 17 36 AM

@shleewhite
Copy link
Contributor Author

shleewhite commented Nov 21, 2024

Small thing, but in the mobile menu, looks like the spacing between the two icons, and between the menu and the edge of the screen are a bit tighter in the figma.

Figma

Screenshot 2024-11-21 at 10 28 05 AM Current UI Screenshot 2024-11-21 at 10 28 15 AM

Thanks for catching that @dchyun!! it should be better now.

Copy link
Contributor

@majedelass majedelass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment about the space between the logo (Helios Design System) and the nav links. From what I could tell, that was it! Nice work :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants