-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDS Content - Adding Writing Guidelines and Writing Style #2576
base: hds-4159/website-nav-update
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Image added to the Date/Time docs
…specific to that. Added illustrations and content images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely written!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nitpicky comments but this looks great
Co-authored-by: LilithJames-HDS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions/comments on the new page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left numerous comments (apologies for the noise!), but only a few are blocking. I'll let you know when I can connect with Coon about the Voice and tone content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, left a bunch of comments on this around formatting and with some suggestions. LMK if you want to pair or if additional context is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revisions! Left two nit pick comments, otherwise it looks great 👍🏻
|
||
!!! | ||
|
||
## Punctuation | ||
|
||
### Serial/Oxford comma | ||
|
||
Use the serial (“Oxford”) comma in lists. | ||
Use the [serial (“Oxford”)](https://www.grammarly.com/blog/punctuation-capitalization/what-is-the-oxford-comma/) comma in lists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the [serial (“Oxford”)](https://www.grammarly.com/blog/punctuation-capitalization/what-is-the-oxford-comma/) comma in lists. | |
Use the [serial (“Oxford”) comma](https://www.grammarly.com/blog/punctuation-capitalization/what-is-the-oxford-comma/) in lists. |
@@ -277,13 +282,15 @@ We are excited to announce Vault 1.3! | |||
|
|||
### Percentages | |||
|
|||
Use the % symbol instead of spelling out "percent." Correct: 50% | |||
Use the % symbol instead of spelling out "percent"; e.g. , `50%`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the % symbol instead of spelling out "percent"; e.g. , `50%`. | |
Use the % symbol instead of spelling "percent," e.g., `50%`. |
|
||
- Terraform Registry | ||
- Terraform Stacks | ||
- Raft algorithm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be:
- Raft algorithm | |
- Raft Algorithm |
|
||
Use an en dash (–) to indicate a range or span of numbers. | ||
|
||
![Text saying "Event dates Sep 20 – Sep 24, 2020"](/assets/content/writing-style/writing-style-punctuation-en-dashes.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be regular spaces before and after the en dash
![Text saying "Event dates Sep 20 – Sep 24, 2020"](/assets/content/writing-style/writing-style-punctuation-en-dashes.png) | |
![Text saying "Event dates Sep 20–Sep 24, 2020"](/assets/content/writing-style/writing-style-punctuation-en-dashes.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since its just normal text, you can just have the alt text be what it says.
![Text saying "Event dates Sep 20 – Sep 24, 2020"](/assets/content/writing-style/writing-style-punctuation-en-dashes.png) | |
![Event dates Sep 20–Sep 24, 2020](/assets/content/writing-style/writing-style-punctuation-en-dashes.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates and follow-up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin good! I found a couple more minor items I added suggested changes for.
These formatting options are available in the [Time](#) component. Choose the format most appropriate for your user needs. | ||
|
||
- **Relative date**: Displays time in relative terms, e.g., "3 hours ago" or "in 2 days". This format is recommended for recent events, particularly within the past or upcoming week, as it simplifies recognition of time-sensitive actions. | ||
- **Friendly date**: Provides a user-friendly date and time, e.g., "Sep 5, 2018, 3:30 PM EST". Ideal for displaying the date and time to who, or what, set it. Limit time format to the minute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: it may just be me, but I am not really sure what "Ideal for displaying the date and time to who, or what, set it" means. what does it mean to display a time to what set it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it's confusing.
|
||
![A modal that has a form to edit an organization. The title is "Edit organization name" and the save button is "Save organization".](/assets/content/writing-style/writing-style-consistent-termonology-CTA-save-do.png) | ||
|
||
![A form to invite users by inputting their emails](/assets/content/writing-style/writing-style-consistent-termonology-CTA-invite-do.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![A form to invite users by inputting their emails](/assets/content/writing-style/writing-style-consistent-termonology-CTA-invite-do.png) | |
![A form to invite users by inputting their emails. The title is "Invite users" and the submit button is "Invite users".](/assets/content/writing-style/writing-style-consistent-termonology-CTA-invite-do.png) |
|
||
Use an en dash (–) to indicate a range or span of numbers. | ||
|
||
![Text saying "Event dates Sep 20 – Sep 24, 2020"](/assets/content/writing-style/writing-style-punctuation-en-dashes.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since its just normal text, you can just have the alt text be what it says.
![Text saying "Event dates Sep 20 – Sep 24, 2020"](/assets/content/writing-style/writing-style-punctuation-en-dashes.png) | |
![Event dates Sep 20–Sep 24, 2020](/assets/content/writing-style/writing-style-punctuation-en-dashes.png) |
|
||
Use the % symbol instead of spelling out "percent"; e.g. , `50%`. | ||
|
||
![A card showing usage data, along side its status and name](/assets/content/writing-style/writing-style-punctuation-percentage.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![A card showing usage data, along side its status and name](/assets/content/writing-style/writing-style-punctuation-percentage.png) | |
![A card showing usage data, along side its status and name. It includes the text "12%" with an up arrow icon to inform users the requests have increased.](/assets/content/writing-style/writing-style-punctuation-percentage.png) |
📌 Summary
If merged, this PR will apply content to the content section for both the "Voice and Tone" and "Writing for UI Copy" docs.
🔗 External links
Jira ticket: HDS-4183
Jira ticket: HDS-4184
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.