Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDS Content - Adding Writing Guidelines and Writing Style #2576

Open
wants to merge 11 commits into
base: hds-4159/website-nav-update
Choose a base branch
from

Conversation

majedelass
Copy link
Contributor

@majedelass majedelass commented Nov 20, 2024

📌 Summary

If merged, this PR will apply content to the content section for both the "Voice and Tone" and "Writing for UI Copy" docs.

🔗 External links

Jira ticket: HDS-4183
Jira ticket: HDS-4184


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

@majedelass majedelass requested review from a team as code owners November 20, 2024 18:05
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Nov 26, 2024 9:15pm
hds-website ✅ Ready (Inspect) Visit Preview Nov 26, 2024 9:15pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Nov 20, 2024
@shleewhite shleewhite changed the base branch from main to hds-4159/website-nav-update November 20, 2024 18:06
@majedelass majedelass marked this pull request as draft November 20, 2024 18:09
Image added to the Date/Time docs
@majedelass majedelass changed the title HDS Content - Adding Voice and Tone and Writing for UI Copy HDS Content - Adding Voice and Tone and Writing Guidelines Nov 25, 2024
…specific to that. Added illustrations and content images
Copy link
Contributor

@zamoore zamoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely written!

Copy link
Contributor

@LilithJames-HDS LilithJames-HDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicky comments but this looks great

website/docs/content/voice-and-tone/index.md Outdated Show resolved Hide resolved
website/docs/content/voice-and-tone/index.md Outdated Show resolved Hide resolved
@majedelass majedelass changed the title HDS Content - Adding Voice and Tone and Writing Guidelines HDS Content - Adding Voice and Tone and Writing Guidelines and Writing Style Nov 25, 2024
@majedelass majedelass changed the title HDS Content - Adding Voice and Tone and Writing Guidelines and Writing Style HDS Content - Adding Voice and Tone, Writing Guidelines and Writing Style Nov 25, 2024
Copy link
Contributor

@LilithJames-HDS LilithJames-HDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions/comments on the new page

website/docs/content/voice-and-tone/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@heatherlarsen heatherlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left numerous comments (apologies for the noise!), but only a few are blocking. I'll let you know when I can connect with Coon about the Voice and tone content.

website/docs/content/voice-and-tone/index.md Outdated Show resolved Hide resolved
website/docs/content/voice-and-tone/index.md Outdated Show resolved Hide resolved
website/docs/content/voice-and-tone/index.md Outdated Show resolved Hide resolved
website/docs/content/voice-and-tone/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-guidelines/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-guidelines/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-guidelines/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jorytindall jorytindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, left a bunch of comments on this around formatting and with some suggestions. LMK if you want to pair or if additional context is necessary.

website/docs/content/voice-and-tone/index.md Outdated Show resolved Hide resolved
website/docs/content/voice-and-tone/index.md Outdated Show resolved Hide resolved
website/docs/content/voice-and-tone/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-guidelines/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
website/docs/content/writing-style/index.md Outdated Show resolved Hide resolved
@majedelass majedelass changed the title HDS Content - Adding Voice and Tone, Writing Guidelines and Writing Style HDS Content - Adding Writing Guidelines and Writing Style Nov 26, 2024
Copy link
Contributor

@heatherlarsen heatherlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions! Left two nit pick comments, otherwise it looks great 👍🏻


!!!

## Punctuation

### Serial/Oxford comma

Use the serial (“Oxford”) comma in lists.
Use the [serial (“Oxford”)](https://www.grammarly.com/blog/punctuation-capitalization/what-is-the-oxford-comma/) comma in lists.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the [serial (“Oxford”)](https://www.grammarly.com/blog/punctuation-capitalization/what-is-the-oxford-comma/) comma in lists.
Use the [serial (“Oxford”) comma](https://www.grammarly.com/blog/punctuation-capitalization/what-is-the-oxford-comma/) in lists.

@@ -277,13 +282,15 @@ We are excited to announce Vault 1.3!

### Percentages

Use the % symbol instead of spelling out "percent." Correct: 50%
Use the % symbol instead of spelling out "percent"; e.g. , `50%`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the % symbol instead of spelling out "percent"; e.g. , `50%`.
Use the % symbol instead of spelling "percent," e.g., `50%`.


- Terraform Registry
- Terraform Stacks
- Raft algorithm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be:

Suggested change
- Raft algorithm
- Raft Algorithm


Use an en dash (–) to indicate a range or span of numbers.

![Text saying "Event dates Sep 20 – Sep 24, 2020"](/assets/content/writing-style/writing-style-punctuation-en-dashes.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be regular spaces before and after the en dash

Suggested change
![Text saying "Event dates Sep 20Sep 24, 2020"](/assets/content/writing-style/writing-style-punctuation-en-dashes.png)
![Text saying "Event dates Sep 20Sep 24, 2020"](/assets/content/writing-style/writing-style-punctuation-en-dashes.png)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since its just normal text, you can just have the alt text be what it says.

Suggested change
![Text saying "Event dates Sep 20Sep 24, 2020"](/assets/content/writing-style/writing-style-punctuation-en-dashes.png)
![Event dates Sep 20Sep 24, 2020](/assets/content/writing-style/writing-style-punctuation-en-dashes.png)

Copy link
Contributor

@jorytindall jorytindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and follow-up!

Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good! I found a couple more minor items I added suggested changes for.

These formatting options are available in the [Time](#) component. Choose the format most appropriate for your user needs.

- **Relative date**: Displays time in relative terms, e.g., "3 hours ago" or "in 2 days". This format is recommended for recent events, particularly within the past or upcoming week, as it simplifies recognition of time-sensitive actions.
- **Friendly date**: Provides a user-friendly date and time, e.g., "Sep 5, 2018, 3:30 PM EST". Ideal for displaying the date and time to who, or what, set it. Limit time format to the minute.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: it may just be me, but I am not really sure what "Ideal for displaying the date and time to who, or what, set it" means. what does it mean to display a time to what set it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's confusing.


![A modal that has a form to edit an organization. The title is "Edit organization name" and the save button is "Save organization".](/assets/content/writing-style/writing-style-consistent-termonology-CTA-save-do.png)

![A form to invite users by inputting their emails](/assets/content/writing-style/writing-style-consistent-termonology-CTA-invite-do.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![A form to invite users by inputting their emails](/assets/content/writing-style/writing-style-consistent-termonology-CTA-invite-do.png)
![A form to invite users by inputting their emails. The title is "Invite users" and the submit button is "Invite users".](/assets/content/writing-style/writing-style-consistent-termonology-CTA-invite-do.png)


Use an en dash (–) to indicate a range or span of numbers.

![Text saying "Event dates Sep 20 – Sep 24, 2020"](/assets/content/writing-style/writing-style-punctuation-en-dashes.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since its just normal text, you can just have the alt text be what it says.

Suggested change
![Text saying "Event dates Sep 20Sep 24, 2020"](/assets/content/writing-style/writing-style-punctuation-en-dashes.png)
![Event dates Sep 20Sep 24, 2020](/assets/content/writing-style/writing-style-punctuation-en-dashes.png)


Use the % symbol instead of spelling out "percent"; e.g. , `50%`.

![A card showing usage data, along side its status and name](/assets/content/writing-style/writing-style-punctuation-percentage.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![A card showing usage data, along side its status and name](/assets/content/writing-style/writing-style-punctuation-percentage.png)
![A card showing usage data, along side its status and name. It includes the text "12%" with an up arrow icon to inform users the requests have increased.](/assets/content/writing-style/writing-style-punctuation-percentage.png)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants