Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private props standardization - modifiers #2583

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dchyun
Copy link
Contributor

@dchyun dchyun commented Nov 25, 2024

📌 Summary

As part of the ongoing standardization of private properties and methods, the private properties of internal modifiers have been updated to reflect the new naming convention of private _propertyName.

🛠️ Detailed description

In this PR I have updated the properties for the following modifiers

  • hds-anchored-position
  • hds-register-events
  • hds-tooltip

🔗 External links

Jira ticket: HDS-2508

👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Nov 25, 2024 10:50pm
hds-website ✅ Ready (Inspect) Visit Preview Nov 25, 2024 10:50pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants