-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cryptoutil/rsa, RSA key generation using a seeded DRBG #141
Open
sgmiller
wants to merge
16
commits into
main
Choose a base branch
from
sgm/prng-rsa
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e primes rather than using a random source directly
…e primes rather than using a random source directly
… into sgm/prng-rsa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, some small nits
stevendpclark
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Vault with entropy augmentation, we may be sourcing randomness from a
particularly slow HSM. RSA needs to generate potentially hundreds of candidate numbers to find primes,
and if using direct entropy to do this, requires quite a lot of random bytes.
Some customers have seen multiple minute key generation times as a result.
This PR implements RSA key generation where a NIST HMAC DRBG is seeded
from the random source, which is then used to unpredictably generate candidate primes,
resulting in a 5000 - 20000x increase in performance on these slow HSMs.
Additionally, these functions test whether the underlying random source
is crypto/rand, and if so, skips this process and behaves as before.