Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cryptoutil/rsa, RSA key generation using a seeded DRBG #141

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

sgmiller
Copy link
Contributor

@sgmiller sgmiller commented Nov 15, 2024

In Vault with entropy augmentation, we may be sourcing randomness from a
particularly slow HSM. RSA needs to generate potentially hundreds of candidate numbers to find primes,
and if using direct entropy to do this, requires quite a lot of random bytes.
Some customers have seen multiple minute key generation times as a result.

This PR implements RSA key generation where a NIST HMAC DRBG is seeded
from the random source, which is then used to unpredictably generate candidate primes,
resulting in a 5000 - 20000x increase in performance on these slow HSMs.

Additionally, these functions test whether the underlying random source
is crypto/rand, and if so, skips this process and behaves as before.

Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, some small nits

cryptoutil/rsa.go Outdated Show resolved Hide resolved
cryptoutil/go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants