plugin/ecs: cannot destroy deployments

[izaaklauer]

Describe the bug
I'm attempting to manually delete the second-to-last waypoint deployment, and I get this error:

$ waypoint deployment list -workspace=prod

» acmeapp1
     | ID | PLATFORM |  DETAILS   |    STARTED    |   COMPLETED   |      HEALTH        
-----+----+----------+------------+---------------+---------------+--------------------
  🚀 | 15 | aws-ecs  | artifact:2 | 6 minutes ago | 6 minutes ago | ● - 6 minutes ago  
  ✔  | 14 | aws-ecs  | artifact:2 | 8 minutes ago | 8 minutes ago | ● - 8 minutes ago  

$ waypoint deployment destroy 14

» Destroying deployments for acmeapp1

» 1 deployments will be destroyed.
  Destroying deployment: 01GQV0DYRFQWK6XZN311P4QYMX

» Operation is queued waiting for job "01GQV0X723FB3S7TPQW5W63Y42". Waiting for runner assignment...
  If you interrupt this command, the job will still run in the background.
  Performing operation on "aws-ecs" with runner profile "ecs-01GQJJP4GH4PXEDHNZPY8ZA6W7"

» Cloning data from Git
         URL: https://api.hashicorp.cloud/waypoint/2022-04-21/github/clone/hashicorp/waypoint-learn-terraform-aws-ecs
         Ref: main
        Auth: username/password
  Git Commit: 511720182f674ce9fc06eea5d528c64ffaee682c
   Timestamp: 2023-01-28 01:34:45 +0000 UTC
     Message: better cpu value
  
  mem is probably wrong though!
  
✓ Running deployment destroy v14
❌ Destroying ecs deployment...
✓ Deleted service acmeapp1-01GQV0DYYGQ58SH3MSHEW0H
❌ Deleting target group acmeapp1-01GQV0DYYGQ58SH3MSHEW0H
! Error destroying deployment 14: rpc error: code = Internal desc = failed to destroy all resources for deployment: rpc error: code = Internal desc = failed to
delete target group acmeapp1-01GQV0DYYGQ58SH3MSHEW0H (ARN:
"arn:aws:elasticloadbalancing:us-east-1:863953081260:targetgroup/acmeapp1-01GQV0DYYGQ58SH3MSHEW0H/5aff44d18c6b8299"): ResourceInUse: Target group
'arn:aws:elasticloadbalancing:us-east-1:863953081260:targetgroup/acmeapp1-01GQV0DYYGQ58SH3MSHEW0H/5aff44d18c6b8299' is currently in use by a listener or a rule
  	status code: 400, request id: dfc5a7ad-a1a6-4f26-9b0d-60507e4e5316

Because this is the second-to-most-recent deployment, it's left in the alb listener, but taking zero traffic. Waypoint isn't removing it from the listener, so aws refuses to destroy it.

Workaround
I manually edited the ALB listener to remove the target group.

Steps to Reproduce
Steps to reproduce the behavior.

• Clone https://github.com/hashicorp/waypoint-examples/tree/main/aws/aws-ecs/nodejs
• Run waypoint up twice
• Try to delete deployment number 1

Expected behavior
If the deployment isn't taking traffic, waypoint should delete it.

If the deployment is taking traffic, deleting the release with waypoint release destroy

Waypoint Platform Versions
Additional version and platform information to help triage the issue if
applicable:

• Waypoint CLI Version: v0.5.1
• Waypoint Server Platform and Version: (like docker, nomad, kubernetes)
• Waypoint Plugin: (like aws/ecs, pack, azure)

Additional context

We should also consider the procedure for deleting all deployments, which is what I was trying to do.