-
Notifications
You must be signed in to change notification settings - Fork 139
internal / underlying blake2 symbols aren't mangled or private #109
Comments
as a bit of context haskell-hvr/argon2#10 and
|
Lines 266 to 277 in 3c087f0
seems to be the offending bit, and those implementations dont have the name mangling and they're not static function impls |
@cartazio What is the output of:
|
i'm on mac osx.... On Thu, Nov 3, 2016 at 2:06 PM, John Galt [email protected] wrote: |
what would the appropriate command analogue there? On Thu, Nov 3, 2016 at 2:35 PM, Carter Schonwald <[email protected]
|
I don't use OSX so I don't know. This could be helpful though: http://stackoverflow.com/questions/3286675/readelf-like-tool-for-mac-os-x |
might be much faster to port the tiny argon library (specially considering that blake is already in) to cryptonite than muck around the blake C files; Obviously would be nice to solve the exports list problem too, but need much more careful thoughts. |
Port? I do know that if Argon2 is set to dyload the libargon that the collision But yeah, I'll get yah yer info On Thursday, November 3, 2016, Vincent Hanquez [email protected]
|
That said, I'm not sure if OS X supports the hidden symbol attribute on On Thursday, November 3, 2016, Carter Schonwald [email protected]
|
port = adding argon2 in cryptonite. |
@cartazio Is this still an issue for you? |
it is an issue, but it looks like cryptonite isn't willing to consider
mangling private symbols to make sure they're not conflicting on OSX, so it
sounds like any projects that have this collision just have to maintain a
vendored version of one lib or the other :(
…On Tue, Dec 20, 2016 at 2:03 PM, John Galt ***@***.***> wrote:
@cartazio <https://github.com/cartazio> Is this still an issue for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#109 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAQwqSQ4Anj2iEYNO0gMV-l2EaCLJydks5rKCadgaJpZM4KoaO->
.
|
I think the proper solution is to ensure that the symbols are hidden properly. Is there really no way to do this with static libraries on OSX? |
yes, prefix them with `cryptonite_` or something similar like
`cryptoniteHS_ `is probably the only approach that will be properly robust,
and is generally good practice :)
as best as I understand it, the core mach / mach-o stuff on macOS is
really dynamic linker first. if you have specific mac code experiments
you'd like me to do, i'm happy to copy and paste them, but based on my own
investigations, name mangling is the ONLY robust solution in the presence
of static linking. everything else has sharp bits and gotchas. (and thats
also ignoring the fact that you cant quite do relocatable dylib lookups
sortah on macOS, so static linking is favored for simple binaries that
aren't in a .app or the like)
…On Tue, Dec 20, 2016 at 2:54 PM, John Galt ***@***.***> wrote:
I think the proper solution is to ensure that the symbols are hidden
properly. Is there really no way to do this with static libraries on OSX?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#109 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAQwqIu9biu8W7YV29K2ejTYSH8bZleks5rKDJigaJpZM4KoaO->
.
|
For the blake2 source files in cryptonite, everywhere you see |
argon2 is now in cryptonite |
Sweet. Thanks.
…On Fri, Feb 24, 2017 at 8:58 AM Vincent Hanquez ***@***.***> wrote:
argon2 is now in cryptonite
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#109 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAQwiVZ9JenPxwYOhwwDZpOYOx2qMopks5rfuIXgaJpZM4KoaO->
.
|
I'm helping some folks with some crypto heavy code and this change would make our lives much easier. If I helped get this sorted, would it be possible to turn around a release with that hange pretty fast ?
The text was updated successfully, but these errors were encountered: