Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in ColorJitter #8

Open
Kennard123661 opened this issue Mar 12, 2020 · 4 comments
Open

Bug in ColorJitter #8

Kennard123661 opened this issue Mar 12, 2020 · 4 comments

Comments

@Kennard123661
Copy link

Hi @hassony2 , I think there is a bug here where it should be

        for img in clip:
            for func in img_transforms:
                img = func(img)
            jittered_clip.append(img)
@xmengli
Copy link

xmengli commented Aug 9, 2020

@Kennard123661

I think you are correct. This is a bug in the code.
Another way is:

        jittered_clip = []
        for img in clip:
            jittered_img = img.copy()
            for func in img_transforms:
                jittered_img = func(jittered_img)
            jittered_clip.append(jittered_img)

I think in this way, the color transformation will be applied for each clip independently.

@LiUzHiAn
Copy link

LiUzHiAn commented Jun 7, 2021

@Kennard123661 , @xmengli999 ,

I agree with you guys, let me make a PR, check it out here :)

LiUzHiAn added a commit to LiUzHiAn/torch_videovision that referenced this issue Jun 7, 2021
@SmallXieGithub
Copy link

Hi, I have a question. Should I use ColorJitter for non-RGB modalities?

@Ghelman-A
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants