You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description: Description
The method distributeRewards can be called again for the same campaign to correct a mistake.
If in the meanwhile a claim could have been processed and it is irreversible. and could drain the funds which by right should be assigned to another address.
The likelyhood of this issue is very low, however the severity is medium. Attack Scenario\
The updater account performs distributeRewardsand assigns 1 WETH to Alice and 1 WETH to Bob.
Bob claims the 1 WETH.
The updater noticed the assignment should be 2 WETH to Alice and no WETH to Bob and performs another distributeRewards.
Now it is too late as Bob has already claimed 1 WETH and Alice can only claim 1 WETH (instead of 2).
The text was updated successfully, but these errors were encountered:
The backend is coded so that claims are ever-increasing. A claim can never be reduced in quantity, only increased, and the smart contract keeps track of how much reward has already been claimed so double claim risks are neutralized.
Github username: @skypper
Twitter username: tudoratu
Submission hash (on-chain): 0x0c4f668567bc6045f828f9c0ea56129743e2a4d14a6db4f85399a45bd0abcd62
Severity: medium
Description:
Description
The method
distributeRewards
can be called again for the same campaign to correct a mistake.If in the meanwhile a claim could have been processed and it is irreversible. and could drain the funds which by right should be assigned to another address.
The likelyhood of this issue is very low, however the severity is medium.
Attack Scenario\
updater
account performsdistributeRewards
and assigns 1 WETH to Alice and 1 WETH to Bob.updater
noticed the assignment should be 2 WETH to Alice and no WETH to Bob and performs anotherdistributeRewards
.Now it is too late as Bob has already claimed 1 WETH and Alice can only claim 1 WETH (instead of 2).
The text was updated successfully, but these errors were encountered: