Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom pane specification #6

Open
sheppard opened this issue Oct 14, 2014 · 6 comments
Open

support custom pane specification #6

sheppard opened this issue Oct 14, 2014 · 6 comments

Comments

@sheppard
Copy link
Member

sheppard commented Oct 14, 2014

Incorporate/enable/test the ability to specify a custom leaflet pane for a source (and it's underlying Overlay/Tile layer).

@sheppard
Copy link
Member Author

sheppard commented Nov 4, 2014

@joshdickerson92
Copy link

Has any improvement on this been made yet? Tried to find a workaround on Stack Exchange but not found a solution. @sheppard did Leaflet.NonTiledLayer work for you?

@sheppard sheppard changed the title layer ordering & pane customization support custom pane specification Aug 19, 2016
@sheppard
Copy link
Member Author

This is still pending, PRs are welcome. I don't think it will be a huge change. I haven't tried Leaflet.NonTiledLayer directly but it appears they accept a pane argument.

@sheppard sheppard modified the milestone: 0.3.0 Nov 7, 2016
@sheppard
Copy link
Member Author

As discussed in #19, multiple sources can get out of order when panning and it's not clear that #28 is sufficient to address. Thus, panes are probably the easiest and most robust way to ensure that layer order remains the same when using multiple sources (c.f. Esri/esri-leaflet#1000).

@peter-alexander
Copy link

I ran into the same problem. I want to use a wms source (only one layer) as the basemap but it ends up on top of everything else.

So I think this should be filed as a bug not an enhancement.

@gregallensworth
Copy link

For simple use case with a L.WMS.Overlay you may find this simple four-line patch relevant: https://github.com/GreenInfo-Network/leaflet.wms/blob/gh-pages/src/leaflet.wms.js#L405-L412

This is a patch into the L.WMS.Overlay update() method, to look for a pane option that was passed in, and move the resulting image overlay into the pane.

This does not address the more complex use cases, but hopefully someone using Overlay will find it useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants