Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions ext-dom and ext-calendar missing in composer.json #171

Open
dweichert opened this issue Mar 22, 2024 · 0 comments · May be fixed by #172
Open

Extensions ext-dom and ext-calendar missing in composer.json #171

dweichert opened this issue Mar 22, 2024 · 0 comments · May be fixed by #172

Comments

@dweichert
Copy link

\Org_Heigl\Holidaychecker\IteratorItem\Easter relies on functions provided by ext-calendar.

DOMElement (used in \Org_Heigl\Holidaychecker\Factory\SwapDecoratorFactory) is provided by ext-dom.

Instead of requiring ext-calendar it is also possible to require roukmoute/polyfill-calendar. This is nice, because it will provide the functions needed for the Easter calculation when ext-calendar is missing and will do nothing if not.
dweichert added a commit to dweichert/holidayChecker that referenced this issue Mar 22, 2024
@dweichert
Require extensions/polyfills (heiglandreas#171)
502a420
dweichert added a commit to dweichert/holidayChecker that referenced this issue Mar 22, 2024
@dweichert
Merge pull request #1 from dweichert/dweichert-patch-171
87f9dc3 
Require extensions/polyfills (heiglandreas#171)
@dweichert dweichert linked a pull request Mar 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require extension (ext-dom) and polyfill (ext-calendar) dweichert/holidayChecker
1 participant
@dweichert