Add early linky (G1 pilote) #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for experimental/pilote ADS (65 to 68)
Handle protocol deviation for early ADS. Currently ADS 67 only is concerned. 68 could also be concerned. Deviation : SINSTS -> SINST1 SMAXSN -> SMAXN, SAMXSN-1 -> SMAXMN-1
This was referenced Oct 29, 2024
|
Je l'ai adapté par rapport à #32 j'espère ne rien avoir cassé |
|
Dites moi si tout fonctionne comme il faut: |
Malheureusement il y a des doublons de capteurs qui dupliquent des ID des entités concernés par cette PR ! 💥
Rien de grave, je vais lancer une PR corrective |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following my experience, it seams that there is early Linky (G1 pilote 90A, ADS type 67) with protocol deviation in standard mode. May also concern G1 pilote 60A, ADS type 68.
Not tested in historic mode.
Not tested in producer mode.
SINSTS is replaced by SINST1
SMAXSN is replaced by SMAXN
SMAXSN-1 is replaced by SMAXN-1
This PR add detection of early Linky models and a way to handle automatically protocol variation based on ADS code.
Solve issue #41 and #42