From 0e01432371e411f7a9988002a081df275e25a45f Mon Sep 17 00:00:00 2001 From: Benjamin Klum Date: Tue, 27 Aug 2024 09:48:57 +0200 Subject: [PATCH] #1119 Make ENTER and OSC/keyboard slot trigger act just like normal triggering --- main/src/domain/targets/playtime_slot_transport_target.rs | 5 +++-- playtime-clip-engine | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/main/src/domain/targets/playtime_slot_transport_target.rs b/main/src/domain/targets/playtime_slot_transport_target.rs index e7fd63b98..975be5168 100644 --- a/main/src/domain/targets/playtime_slot_transport_target.rs +++ b/main/src/domain/targets/playtime_slot_transport_target.rs @@ -152,7 +152,7 @@ mod playtime_impl { // This action is special in that it some of it can be carried out directly in the real-time // thread **but not everything**! Other parts can only be done from main thread, such as // starting to record into an empty slot and/or auto-activating the triggered slot. The - // stuff done in the main thread (play/stop) must NOT be repeated here. + // stuff done in the real-time thread (play/stop) must NOT be repeated here. let velocity = value.to_unit_value().map_err(anyhow::Error::msg)?; matrix.trigger_slot( self.basics.slot_address, @@ -163,7 +163,8 @@ mod playtime_impl { .options .stop_column_if_slot_empty, allow_activate: true, - // If control was initiated from real-time target, don't take care of starting/stopping. + // If control was initiated from real-time context (MIDI), don't take care of + // starting/stopping. Because it's done in the real-time matrix already. allow_start_stop: !context.coming_from_real_time, }, )?; diff --git a/playtime-clip-engine b/playtime-clip-engine index 375009086..d8ee69fda 160000 --- a/playtime-clip-engine +++ b/playtime-clip-engine @@ -1 +1 @@ -Subproject commit 375009086e14c599d620187ef538bc54626b20ed +Subproject commit d8ee69fda95d6ab02a3943b3227b3174440ca258