Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: Adds ability to close idle HTTP connections after a certain time #9194

Merged
merged 2 commits into from
Aug 27, 2024
Merged

3.x: Adds ability to close idle HTTP connections after a certain time #9194

merged 2 commits into from
Aug 27, 2024

Conversation

spericas
Copy link
Member

@spericas spericas commented Aug 23, 2024 •
edited
Loading

Description

Adds ability to close idle HTTP connections after a certain time using connection-idle-timeout (in seconds). New test. See issue #9163.

Configuration

 webServer = WebServer.builder()
                      .host("localhost")
                      .port(port)
                      .connectionIdleTimeout(300)      // 5 minutes
                      ...
server:
  host: localhost
  port: 0
  connection-idle-timeout: 300

@spericas
Adds ability to close idle HTTP connections after a certain time usin…
f02ea09 
…g connection-idle-timeout (in seconds). New test.
@spericas spericas added enhancement New feature or request webserver 3.x Issues for 3.x version branch labels Aug 23, 2024
@spericas spericas added this to the 3.x milestone Aug 23, 2024
@spericas spericas self-assigned this Aug 23, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 23, 2024
barchetta
barchetta reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a config snippet to the PR description?

webserver/webserver/src/main/java/io/helidon/webserver/SocketConfiguration.java Outdated Show resolved Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/SocketConfiguration.java Outdated Show resolved Hide resolved
@spericas
Updates test after further testing on Linux.
fb5cfa5 
Signed-off-by: Santiago Pericas-Geertsen <[email protected]>
@barchetta barchetta modified the milestones: 3.x, 3.2.10 Aug 23, 2024
@spericas spericas requested a review from barchetta August 23, 2024 20:07
@spericas spericas changed the title Adds ability to close idle HTTP connections after a certain time 3.x: Adds ability to close idle HTTP connections after a certain time Aug 26, 2024
@spericas spericas merged commit 2b333d7 into helidon-io:helidon-3.x Aug 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@barchetta barchetta Awaiting requested review from barchetta

Assignees

@spericas spericas

Labels
3.x Issues for 3.x version branch enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement. webserver
Projects
Backlog
Archived in project
Milestone
3.2.10
Development

Successfully merging this pull request may close these issues.
3 participants
@spericas @romain-grecourt @barchetta