3.x: Support built-in health check config at health.checks (retaining now-deprecated helidon.health for compatibility)
#9337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aintaining bw compat at helidon.health Signed-off-by: Tim Quinn <[email protected]>
…tual change in value
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
previously approved these changes
Oct 8, 2024
romain-grecourt
changed the title
health.checks (retaining now-deprecated helidon.health for compatibility)health.checks (retaining now-deprecated helidon.health for compatibility)
…fig with proxied config objects
barchetta
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9322
The PR allows (and encourages, through changes in the doc and Javadoc) the use of
health.checks(preferred overhelidon.health) as the prefix for config keys to control the built-in health checks.The now-deprecated
helidon.healthprefix still works although its use triggers a warning courtesy of the new utility classDeprecatedMpConfig. (This is patterned closely after the existingDeprecatedConfigclass but that does not work with proxied MPConfigobjects.)There are some public constants which retain their old values (even though the syntax for how they are computed has changed) so any user code relying on the previous values will continue to work unchanged.
The Javadoc and the
.adocdoc now refer tohealth.checksas the config prefix.A few tests added.
Documentation
Doc is updated.