-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes ApplicationPath a bean defining annotation #9582
base: main
Are you sure you want to change the base?
Conversation
… that shows support for this new feature.
|
||
/** | ||
* Use {@link ApplicationPath} as a bean-defining annotation (BDA). Note that | ||
* there is no CDI scope annotation on the class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(…which normally means it is therefore in @Dependent
scope, since you've made it a bean. Is that OK? Maybe @ApplicationPath
should be a CDI stereotype, which can explicitly include scopes?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in the same way resources are in @Dependent
scope by default. Jersey should still create an instance "per application".
Personally I'm mildly -1 for these kinds of changes, as making |
I understand, but as @romain-grecourt pointed out, it is inconsistent the way it is now between |
Description
Makes
@ApplicationPath
a bean defining annotation. New functional test that shows support for this new feature.See #8502
Documentation
Needs to be updated