Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for terminals implementing only the first progressive enhancement level of the Kitty Keyboard Protocol #12232

Open
Iorvethe opened this issue Dec 10, 2024 · 0 comments
Assignees
Labels
C-enhancement Category: Improvements

Comments

@Iorvethe
Copy link
Contributor

Currently Helix assumes that if a terminal supports the first level “Disambiguate escape codes”, then it also supports the second one, namely “Report alternate keys”. This unfortunately results in some bindings not working in some terminal emulators/multiplexers such as Zellij. See zellij-org/zellij#3789 (comment) for a comment by Zellij’s maintainer on the issue.

It would be nice if Helix could query the supported subset of the protocol by the terminal and act accordingly. From what I understand, Helix uses crossterm for this, which only returns a boolean. An issue was also opened on their repo for a more granular query function, which Helix could then use (see crossterm-rs/crossterm#952). In the meantime, could Helix maybe do the query itself?

@Iorvethe Iorvethe added the C-enhancement Category: Improvements label Dec 10, 2024
@the-mikedavis the-mikedavis self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

2 participants