Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Herbs project must to born with Dockerfile #13

Open
italojs opened this issue Aug 19, 2021 · 6 comments
Open

Herbs project must to born with Dockerfile #13

italojs opened this issue Aug 19, 2021 · 6 comments
Labels
enhancement New feature or request good-4-beginners hacktoberfest ready-to-work Item is ready to work on it severity-nice-to-have Item is nice to have

Comments

@italojs
Copy link
Member

italojs commented Aug 19, 2021

I was thinking the herbs-cli could have an option to create the project with an setup config, example

>herbs new
>Do you need a setup config file? [y/N] y
- Make file
- Dockerfile
- Dockerfile + docker-compose
- container engine1
- container engine2
@italojs italojs added the enhancement New feature or request label Aug 19, 2021
@ssmaciel
Copy link

ssmaciel commented Nov 30, 2021

When you say 'container engine1' and 'container engine2', do you mean to generate the Kubernetes manifest files?

Example:

 >herbs new
 >Do you need a setup config file? [y/N] y
 - Make file
 - Dockerfile
 - Dockerfile + docker-compose
 - Kubernetes - Pod
 - Kubernetes - Pod + Service

@italojs
Copy link
Member Author

italojs commented Nov 30, 2021

it could be an option too

@jhomarolo jhomarolo added ready-to-work Item is ready to work on it severity-nice-to-have Item is nice to have and removed effort:easy labels Dec 22, 2021
@jhomarolo
Copy link
Contributor

@ssmaciel can you take this issue?

@dalssoft
Copy link
Member

dalssoft commented Jul 1, 2022

I'm not convinced we should have this kind of boilerplate on herbs cli given it has no direct relationship with Herbs capabilities

@jhomarolo
Copy link
Contributor

I thought the idea of the cli was to evolve to a place close to a real application.

Since many applications today already use docker and/or kubernetes, the application to come with a preconfigured file would make sense in my opinion.

@maikmb
Copy link

maikmb commented Jul 5, 2022

I agree with @jhomarolo! HERBS are for real life and many applications today run in containers. As an option in the CLI, I think it's an interesting improvement.

@jhomarolo jhomarolo moved this to More discussion is needed in Herbs - 3rd Anniversary Edition Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good-4-beginners hacktoberfest ready-to-work Item is ready to work on it severity-nice-to-have Item is nice to have
Projects
Status: More discussion is needed
Development

No branches or pull requests

5 participants