Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for entities #83

Open
dalssoft opened this issue Dec 18, 2021 · 6 comments
Open

Tests for entities #83

dalssoft opened this issue Dec 18, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request hacktoberfest ready-to-work Item is ready to work on it severity-minor Item is not urgent

Comments

@dalssoft
Copy link
Member

The only test currently being generated (from new or update command) is use case tests.

Since entities also can (and should) have logic, they should have tests for entities as well.

ex:
\src\domain\entities\user.js
\src\domain\entities\user.test.js

@dalssoft dalssoft added the enhancement New feature or request label Dec 18, 2021
@jhomarolo jhomarolo added ready-to-work Item is ready to work on it severity-minor Item is not urgent labels Dec 24, 2021
@dalssoft dalssoft moved this to More discussion is needed in Herbs - 3rd Anniversary Edition Jun 27, 2022
@maikmb
Copy link

maikmb commented Jul 5, 2022

@dalssoft This test is for entities generated by the CLI? When you generate a new entity, It does not have logic yet.

@dalssoft
Copy link
Member Author

dalssoft commented Jul 5, 2022

This issue is pre-spec/aloe but the idea remains valid. In order to implement this issue, first it is necessary to add a spec to entities on aloe.

Once we have this feature there we could have a generated spec files to each entity or at least for the first entity (User) as an example

@maikvortx
Copy link

Yes, I agree! We can have at least one user.spec file in the herbs-cli template.

@RafaelStutz
Copy link

I can work on this issue.

@jhomarolo jhomarolo moved this from More discussion is needed to In Progress in Herbs - 3rd Anniversary Edition Jul 12, 2022
@italojs
Copy link
Member

italojs commented Oct 5, 2022

@RafaelStutz are you still working on this?

@dalssoft
Copy link
Member Author

FYI, CLI can now run specs without use case metadata: #169

With that, it is just a matter of creating templates for the entities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest ready-to-work Item is ready to work on it severity-minor Item is not urgent
Projects
Status: In Progress
Development

No branches or pull requests

6 participants