Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #14 #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue #14 #15

wants to merge 1 commit into from

Conversation

reunanen
Copy link

@reunanen reunanen commented Aug 30, 2024

Resolves #14.

@@ -102,7 +102,7 @@ template<class T, size_t N>
size_t NumOfArray(const T (&)[N]) { return N; }

/*
exp(88.722839f) = inf ; 0x42b17218
exp(88.722839f) = 1.65163596e+038f ; 0x42b17218
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that previously, infinity was returned almost by accident (and as said, not for inputs such as 89.0f). Now, as the input is explicitly clamped, this same value will be returned for all inputs that are greater than 88.

However, I did not try the Xbyak version. Guessing it would be good if the exact return values were equal...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exp(89.0f) is NaN
1 participant