Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin for using hesim inline #122

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Add plugin for using hesim inline #122

merged 8 commits into from
Jul 16, 2024

Conversation

mclements
Copy link
Collaborator

Devin: can you check this addition, please? It should allow for using hesim inline. Kindly, Mark.

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 92.36%. Comparing base (e218e24) to head (c0ae167).

❗ Current head c0ae167 differs from pull request most recent head 979b098. Consider uploading reports for the commit 979b098 to get more accurate results

Files Patch % Lines
R/utils.R 0.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   92.51%   92.36%   -0.15%     
==========================================
  Files          64       64              
  Lines        5544     5553       +9     
==========================================
  Hits         5129     5129              
- Misses        415      424       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mclements
Copy link
Collaborator Author

I have now made the inline plugin internal -- which addresses an issue with .pkgdown.

@mclements mclements closed this Mar 18, 2024
@mclements
Copy link
Collaborator Author

mclements commented Mar 18, 2024

Closing and re-opening to re-check:)

(I now realise that this is not needed)

@mclements mclements reopened this Mar 18, 2024
Copy link
Member

@dincerti dincerti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mclements. Just a couple of minor comments. Also just curious: what is your intended use case for this?

R/utils.R Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
@dincerti dincerti merged commit f1c32cc into hesim-dev:main Jul 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants