-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin for using hesim inline #122
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 92.51% 92.36% -0.15%
==========================================
Files 64 64
Lines 5544 5553 +9
==========================================
Hits 5129 5129
- Misses 415 424 +9 ☔ View full report in Codecov by Sentry. |
I have now made the inline plugin internal -- which addresses an issue with .pkgdown. |
Closing and re-opening to re-check:) (I now realise that this is not needed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mclements. Just a couple of minor comments. Also just curious: what is your intended use case for this?
Devin: can you check this addition, please? It should allow for using
hesim
inline. Kindly, Mark.