-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress animation is rendered on a new line when the terminal is too small #767
Labels
Comments
We could have different rendering depending on the terminal width. It might not make sens to display the progress if you don't have any space to show it. |
jooola
added a commit
that referenced
this issue
Jun 5, 2024
- Reduce the width of the actions messages (remove 'to complete') - Only print progress when the terminal width is bigger than 80. - Reduce the padding when printing the actions messages Fixes #767
phm07
pushed a commit
that referenced
this issue
Jun 20, 2024
🤖 I have created a release *beep* *boop* --- ## [1.44.0](v1.43.1...v1.44.0) (2024-06-20) ### Features * delete multiple resources in parallel ([#761](#761)) ([f2fb321](f2fb321)) * improve toml formatting ([#758](#758)) ([eacb7dd](eacb7dd)) * **load-balancer:** allow specifying health check options in add-service ([#743](#743)) ([2cd08b2](2cd08b2)), closes [#742](#742) * new action waiting progress ([#749](#749)) ([9e30f3f](9e30f3f)) * new configuration system, config subcommand ([#736](#736)) ([d1c6678](d1c6678)) * **server-type:** add deprecated column to list command ([#780](#780)) ([906f864](906f864)) * **server:** add default-ssh-keys option ([#759](#759)) ([9b34d26](9b34d26)) ### Bug Fixes * **firewall:** 'create --rules-file' not working with outbound rules ([#752](#752)) ([2f2be32](2f2be32)), closes [#750](#750) * network list server count format ([#783](#783)) ([f69d261](f69d261)) * track progress if the terminal width allows it ([#768](#768)) ([069fffe](069fffe)), closes [#767](#767) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TL;DR
The progress animation is rendered on a new line if the rendered line is longer than the terminal width.
Expected behavior
The progress animation should not fill the terminal output with new lines, but overwrite the same line with updated values.
Observed behavior
The terminal output if filled with new lines.
Minimal working example
Reduce the size of your terminal enough to see the behavior occur.
Log output
Additional information
We might be facing cheggaaa/pb#171 and cheggaaa/pb#107
The text was updated successfully, but these errors were encountered: