Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method analyze not public in abstract class Transducer #13

Open
johann-petrak opened this issue Jan 9, 2017 · 2 comments
Open

Method analyze not public in abstract class Transducer #13

johann-petrak opened this issue Jan 9, 2017 · 2 comments

Comments

@johann-petrak
Copy link

This means that the abstract base class cannot be used to use a model without caring if it is weighted or unweighted. If there is a good reason why this is not public it should be documented, otherwise the method should be made public in the abstract class.
I also do not understand why this is an abstract class rather than an interface, its only purpose seems to be to declare the common useful method of all transducers (weighted and unweighted) which is really the job of an interface.

@flammie
Copy link
Member

flammie commented Oct 11, 2017

I made a patch/pr before noticing this

@marko-asplund
Copy link

Any progress on this? Omorfi Java interface compilation fails because Omorfi tries to extend analyze.

marko-asplund added a commit to marko-asplund/hfst-optimized-lookup that referenced this issue Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants